-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Session.copy_object() #215
Implement Session.copy_object() #215
Conversation
Signed-off-by: Eric Devolder <[email protected]>
Signed-off-by: Eric Devolder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Eric Devolder <[email protected]>
The CI script fails for the reason described in #216, can this be looked at? I guess it will block all PRs going forward. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite good 👍 . A couple of nitpicks :)
Signed-off-by: Eric Devolder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. LGTM 👍
I just noticed that the template info is explained in the second sentence of the function doc 🤦♂️
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks!
This PR implements
C_CopyObject()
. It takes a template as an optional argument (i.e.Option<&[Attribute]>
).The PR comes along with rustdoc and dedicated test case.